outbound-networking refactoring #3168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
force-pushed
the
allowed-hosts-refactoring
branch
from
6e39bb7 to
7e119db
Compare
itowlson
approved these changes
Jul 15, 2025
lann
force-pushed
the
allowed-hosts-refactoring
branch
from
7e119db to
8cc4346
Compare
Plus a couple of collateral error tweaks. Signed-off-by: Lann Martin <[email protected]>
- Replace HostConfig::List(Vec<String>) with HostConfig::Literal(url::Host) - Reorganize error handling for consistency - Move logic from spin-loader to AllowedHostConfig::is_for_service_chaining Signed-off-by: Lann Martin <[email protected]>
lann
force-pushed
the
allowed-hosts-refactoring
branch
from
8cc4346 to
940574c
Compare
lann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostConfig::List(Vec<String>)withHostConfig::Literal(url::Host)Listwas only ever exactly one itemurl::Hostprovides validation and normalizationHostConfig::literal(host)AllowedHostConfig::is_for_service_chaining, replacing logic inspin-loader